fix: make deals_nearby respect active construction

eseidel · Feb 25, 2024 · 062544b · 062544b
1 parent f9d621e
commit 062544b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/packages/cli/bin/deals_nearby.dart b/packages/cli/bin/deals_nearby.dart
@@ -37,8 +37,11 @@ Future<void> cliMain(FileSystem fs, Database db, ArgResults argResults) async {
       ? agentCache!.headquarters(systemsCache)
       : systemsCache.waypointFromString(startArg)!;
 
-  final jumpGate = systemsCache.jumpGateWaypointForSystem(start.system)!;
-  final construction = constructionSnapshot[jumpGate.symbol];
+  final construction = await centralCommand.computeActiveConstruction(
+    db,
+    agentCache!,
+    systemsCache,
+  );
   centralCommand.activeConstruction = construction;
 
   final exportCache = TradeExportCache.load(fs);
@@ -57,7 +60,7 @@ Future<void> cliMain(FileSystem fs, Database db, ArgResults argResults) async {
   final extraSellOpps = <SellOpp>[];
   if (centralCommand.isContractTradingEnabled) {
     extraSellOpps
-        .addAll(centralCommand.contractSellOpps(agentCache!, contractSnapshot));
+        .addAll(centralCommand.contractSellOpps(agentCache, contractSnapshot));
   }
   if (centralCommand.isConstructionTradingEnabled) {
     extraSellOpps.addAll(centralCommand.constructionSellOpps());

diff --git a/packages/cli/lib/behavior/central_command.dart b/packages/cli/lib/behavior/central_command.dart
@@ -479,22 +479,27 @@ class CentralCommand {
     }
   }
 
-  Future<Construction?> _computeActiveConstruction(Caches caches) async {
+  /// Returns the active construction job, if any.
+  Future<Construction?> computeActiveConstruction(
+    Database db,
+    AgentCache agentCache,
+    SystemsCache systems,
+  ) async {
     if (!isConstructionTradingEnabled) {
       return null;
     }
 
-    if (caches.agent.agent.credits < config.constructionMinCredits) {
+    if (agentCache.agent.credits < config.constructionMinCredits) {
       return null;
     }
 
-    final systemSymbol = caches.agent.headquartersSystemSymbol;
-    final jumpGate = caches.systems.jumpGateWaypointForSystem(systemSymbol);
+    final systemSymbol = agentCache.headquartersSystemSymbol;
+    final jumpGate = systems.jumpGateWaypointForSystem(systemSymbol);
     if (jumpGate == null) {
       return null;
     }
     final construction =
-        await caches.construction.getConstruction(jumpGate.symbol);
+        await ConstructionCache(db).getConstruction(jumpGate.symbol);
     if (construction == null) {
       return null;
     }
@@ -543,7 +548,11 @@ class CentralCommand {
     await updateAvailableMounts(db);
     await _queueMountRequests(caches);
 
-    activeConstruction = await _computeActiveConstruction(caches);
+    activeConstruction = await computeActiveConstruction(
+      db,
+      caches.agent,
+      caches.systems,
+    );
     subsidizedSellOpps = [];
     if (isConstructionTradingEnabled && activeConstruction != null) {
       subsidizedSellOpps = await computeConstructionMaterialSubsidies(