Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nonFunctions adopt test #7

Merged
merged 1 commit into from
May 28, 2024
Merged

Update nonFunctions adopt test #7

merged 1 commit into from
May 28, 2024

Conversation

sebmck
Copy link
Contributor

@sebmck sebmck commented May 26, 2024

It is indeed throwing a TypeError, it just wasn't the TypeError that I believe this test was wanting.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (a1c5ade) to head (2f7eb6e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          28       28           
  Lines         387      387           
  Branches       85       85           
=======================================
  Hits          351      351           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb merged commit 2f7eb6e into es-shims:main May 28, 2024
326 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants