Skip to content

Get rid of redundant geoms_ in world.hpp #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Get rid of redundant geoms_ in world.hpp #199

wants to merge 1 commit into from

Conversation

mikel-zhobro
Copy link

@mikel-zhobro mikel-zhobro commented Apr 14, 2022 •
edited
Loading

Looks like std::vector<Geometry*> geoms_; and size_t num_geoms() const { return geoms_.size(); } in world.hpp are not used anywhere.

@mikel-zhobro mikel-zhobro changed the title Get rid of redundant geoms_ in world.hpp WIP: Get rid of redundant geoms_ in world.hpp Apr 22, 2022
@mikel-zhobro mikel-zhobro force-pushed the patch-1 branch 2 times, most recently from 241db2d to a397205 Compare April 22, 2022 12:35
@mikel-zhobro mikel-zhobro changed the title WIP: Get rid of redundant geoms_ in world.hpp Get rid of redundant geoms_ in world.hpp Apr 22, 2022
@mikel-zhobro
Copy link
Author

Should be ready to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikel-zhobro