Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #9

Open
wants to merge 83 commits into
base: master
Choose a base branch
from
Open

Modernize #9

wants to merge 83 commits into from

Conversation

biow0lf
Copy link

@biow0lf biow0lf commented Mar 17, 2025

Changes:

  1. Remove .coveralls.yml
  2. Remove .travis.yml
  3. Remove Guardfile
  4. Remove broken badge from README.md
  5. Add GitHub Action actionlint
  6. Add GitHub Action rspec
  7. Add rubocop config (draft version)
  8. Add standard config with target ruby version 3.1
  9. Add # frozen_string_literal: true
  10. Make ErrbitPlugin:: IssueTracker pure Abstract class. So, #configured?, #errors, #create_issue, #close_issue, #url and .label, . note, . fields and .icons will raise NoMethodError if not redefined in sub-class.
  11. Rename ValidateIssueTracker to IssueTrackerValidator.
  12. Make ErrbitPlugin::IssueTracker#close_issue required
  13. Adjust tests for new code
  14. Bump version to 0.7.0

@biow0lf biow0lf self-assigned this Mar 17, 2025
@biow0lf biow0lf marked this pull request as ready for review March 20, 2025 22:43
@biow0lf biow0lf requested review from burnettk and stevecrozz March 20, 2025 22:43
@biow0lf
Copy link
Author

biow0lf commented Mar 20, 2025

Do not merge!

Right now, I will check how its works with new Errbot main.

And do not release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant