compiler: Enable warn_deprecated_catch by default

[richcarl]

I think the warnings for deprecated catches should be turned on by default in OTP 29.

[github-actions]

CT Test Results

    27 files     853 suites   6h 5m 47s ⏱️
 8 193 tests  7 915 ✅   278 💤 0 ❌
20 248 runs  18 731 ✅ 1 517 💤 0 ❌

Results for commit 078955c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[richcarl]

Finally a green buld on this too after rebasing.

[bjorng]

OTB approved this pull request yesterday.

Unfortunately, I can't add the PR to our daily builds yet, because out internal CI tries to build rebar3 and https://github.com/erlware/erlware_commons, and both fail to build because they use the old-style catch. I will need to update the CI to disable the warning; I might not be able to do that until next year.

Might I suggest that you submit pull requests to both of those projects to disable the warning?

[richcarl]

Might I suggest that you submit pull requests to both of those projects to disable the warning?

Tried to make a patch, but their build scripts are doing my head in. A quick fix that works for me is to define export ERL_COMPILER_OPTIONS='[nowarn_deprecated_catch]' in your CI when it builds rebar3.

[richcarl]

@bjorng Tristan helped me out: erlang/rebar3#2983

[bjorng]

Can you rebase the branch to remove the merge conflict?