Skip to content

fix: rm which_applications in httpc:set_options/2 #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rm which_applications in httpc:set_options/2 #10307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions lib/inets/src/http_client/httpc.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,20 +698,18 @@ Sets options to be used for subsequent requests.
DomainDesc :: string(),
HostName :: uri_string:uri_string().
set_options(Options, Profile) when is_atom(Profile) orelse is_pid(Profile) ->
IsInetsRunning = [Application || {inets, _, _} = Application <- application:which_applications()] =/= [],
case IsInetsRunning of
true ->
{ok, IpFamily} = get_option(ipfamily, Profile),
{ok, UnixSock} = get_option(unix_socket, Profile),
case validate_options(Options, IpFamily, UnixSock) of
{ok, Opts} ->
httpc_manager:set_options(Opts, profile_name(Profile));
Error ->
Error
end;
_ ->
{error, inets_not_started}
end.
maybe
{ok, CurrOpts} ?= get_options([ipfamily, unix_socket], Profile),
IpFamily = proplists:get_value(ipfamily, CurrOpts),
UnixSock = proplists:get_value(unix_socket, CurrOpts),
{ok, Opts} ?= validate_options(Options, IpFamily, UnixSock),
try
httpc_manager:set_options(Opts, profile_name(Profile))
catch
exit:{noproc, _} ->
{error, inets_not_started}
end
end.

-doc false.
-spec set_option(atom(), term()) -> ok | {error, term()}.
Expand Down
Loading