Skip to content

cap max column sizes for mssql and oracle #10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

cap max column sizes for mssql and oracle #10297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/odbc/c_src/odbcserver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,8 +1337,14 @@ static db_result_msg encode_column_name_list(SQLSMALLINT num_of_columns,
&nullable)))
DO_EXIT(EXIT_DESC);

if(size == 0 && (sql_type == SQL_LONGVARCHAR || sql_type == SQL_LONGVARBINARY || sql_type == SQL_WLONGVARCHAR))
size = MAXCOLSIZE;
if(sql_type == SQL_LONGVARCHAR || sql_type == SQL_LONGVARBINARY || sql_type == SQL_WLONGVARCHAR) {
if(size == 0) {
size = MAXCOLSIZE; /* Default for databases that return 0 */
} else if(size > MAXCOLSIZE) {
size = MAXCOLSIZE; /* Cap excessive sizes from MSSQL/Oracle */
}
/* If size is reasonable (0 < size <= MAXCOLSIZE), keep it as-is for PostgreSQL */
}

(columns(state)[i]).type.decimal_digits = dec_digits;
(columns(state)[i]).type.sql = sql_type;
Expand Down
Loading