Unregister gen_server name in terminate #10285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for every registered process there's a potential race condition where when the process terminates, the supervisor can restart it before the registry processes the DOWN message. This isn't possible to avoid in all situations, but for servers that trap_exit and process `terminate` calls, this is entirely possible. This change implements this adding a call to `gen:unregister_name` just after users `terminate` callback is processed.
CT Test Results 2 files 97 suites 1h 4m 51s ⏱️ Results for commit 83e8109. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for every registered process there's a potential race condition where when the process terminates, the supervisor can restart it before the registry processes the DOWN message.
This isn't possible to avoid in all situations, but for servers that trap_exit and process
terminatecalls, this is entirely possible.This change implements this adding a call to
gen:unregister_namejust after usersterminatecallback is processed.