Adding logic to remove temporary files after CV has been generated #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the
generate_cv.py
script initially removes non-.gitkeep
files from theclean_pages
andclean_images
directories. At the end of this script these files remain in the filesystem. This is kinda messy, especially if we scale out in future by generating multiple CVs at a time.This PR moves the
cleanup_files
function to the end of the script so the filesystem is not polluted after successful runs. Thepathlib
library is used to create thecv_pages
directory at the start of the script, this does not fail if the directory already exists so an unsuccessful run which leaves acv_pages
directory will not block future runs.Both
pathlib
andshutil
are internal libraries so they will be available on all python runtimes.