rpc: speedup Connection::get_date_time #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/get_date_time
branch
from
a801048 to
5dc2de1
Compare
battlmonstr
force-pushed
the
pr/get_date_time
branch
from
5dc2de1 to
39e7ad0
Compare
|
I'm not completely in favour of this change because it introduces a lock shared among the I/O contexts, which means potential lock contention. Anyway, I'm gonna merge this because if/whenever we'll discover that the date/time computation and the associated lock become one of the relevant performance hotspots, we may even decide to remove the date/time entirely or make it compile-time optional. |
canepat
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize away 2% of time spent in get_date_time by caching the current second Date header.