Fixed bugs

Adjusted GUI layout to better fit long strings. Chrome extension: Fixed POST data being incorrectly set. Fixed Unix directory handling in extensions.
erickutcher · Jun 23, 2024 · 504a197 · 504a197
1 parent a9ce4be
commit 504a197
Show file tree

Hide file tree

Showing 10 changed files with 44 additions and 29 deletions.
diff --git a/HTTP_Downloader/HTTP_Downloader.rc b/HTTP_Downloader/HTTP_Downloader.rc
@@ -63,8 +63,8 @@ IDI_ICON_TRAY           ICON                    "icon_tray.ico"
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 1,0,6,1
- PRODUCTVERSION 1,0,6,1
+ FILEVERSION 1,0,6,2
+ PRODUCTVERSION 1,0,6,2
  FILEFLAGSMASK 0x17L
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -81,12 +81,12 @@ BEGIN
         BEGIN
             VALUE "Comments", "HTTP Downloader is made free under the GPLv3 license."
             VALUE "FileDescription", "HTTP Downloader can download files through HTTP(S), FTP(S), and SFTP connections."
-            VALUE "FileVersion", "1, 0, 6, 1"
+            VALUE "FileVersion", "1, 0, 6, 2"
             VALUE "InternalName", "HTTP Downloader"
             VALUE "LegalCopyright", "Copyright � 2015-2024 Eric Kutcher"
             VALUE "OriginalFilename", "HTTP_Downloader.exe"
             VALUE "ProductName", "HTTP Downloader"
-            VALUE "ProductVersion", "1, 0, 6, 1"
+            VALUE "ProductVersion", "1, 0, 6, 2"
         END
     END
     BLOCK "VarFileInfo"

diff --git a/HTTP_Downloader/changelog.txt b/HTTP_Downloader/changelog.txt
@@ -1,3 +1,10 @@
+Version:	1.0.6.2
+Released:	2024-06-23
+
+Adjusted GUI layout to better fit long strings.
+Chrome extension: Fixed POST data being incorrectly set.
+Fixed Unix directory handling in extensions.
+
 Version:	1.0.6.1
 Released:	2024-06-12
 

diff --git a/HTTP_Downloader/dm_version.txt b/HTTP_Downloader/dm_version.txt
@@ -1,4 +1,4 @@
-16778753
-https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.1/HTTP_Downloader_DM_32.zip
-16778753
-https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.1/HTTP_Downloader_DM_64.zip
+16778754
+https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.2/HTTP_Downloader_DM_32.zip
+16778754
+https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.2/HTTP_Downloader_DM_64.zip
diff --git a/HTTP_Downloader/globals.h b/HTTP_Downloader/globals.h
@@ -109,7 +109,7 @@
 #define CURRENT_VERSION_A	1
 #define CURRENT_VERSION_B	0
 #define CURRENT_VERSION_C	6
-#define CURRENT_VERSION_D	1
+#define CURRENT_VERSION_D	2
 
 #define CURRENT_VERSION		( ( CURRENT_VERSION_A << 24 ) | \
 							  ( CURRENT_VERSION_B << 16 ) | \

diff --git a/HTTP_Downloader/version.txt b/HTTP_Downloader/version.txt
@@ -1,4 +1,4 @@
-16778753
-https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.1/HTTP_Downloader_32.zip
-16778753
-https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.1/HTTP_Downloader_64.zip
+16778754
+https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.2/HTTP_Downloader_32.zip
+16778754
+https://github.com/erickutcher/httpdownloader/releases/download/v1.0.6.2/HTTP_Downloader_64.zip
diff --git a/HTTP_Downloader/wnd_proc_cmessagebox.cpp b/HTTP_Downloader/wnd_proc_cmessagebox.cpp
@@ -364,37 +364,37 @@ void AdjustWindowDimensions( HWND hWnd, HWND static_msg, CMSGBOX_INFO *cmb_info,
 	if ( ( cmb_info->type & 0x0F ) == CMB_RENAMEOVERWRITESKIPALL ||
 		 ( cmb_info->type & 0x0F ) == CMB_CONTINUERESTARTSKIPALL )
 	{
-		if ( msgbox_width < ( 283 + cb_width ) )
+		if ( msgbox_width < ( 313 + cb_width ) )
 		{
-			msgbox_width = 283 + cb_width;	// ( 75 + 8 + 75 + 8 + 75 + 10 ) + 32
+			msgbox_width = 313 + cb_width;	// ( 85 + 8 + 85 + 8 + 85 + 10 ) + 32
 		}
 	}
 	else if ( ( cmb_info->type & 0x0F ) == CMB_YESNOALL )
 	{
-		if ( msgbox_width < ( 200 + cb_width ) )
+		if ( msgbox_width < ( 210 + cb_width ) )
 		{
-			msgbox_width = 200 + cb_width;
+			msgbox_width = 210 + cb_width;
 		}
 	}
 	else if ( ( cmb_info->type & 0x0F ) == CMB_YESNO )
 	{
-		if ( msgbox_width < 200 )
+		if ( msgbox_width < 210 )
 		{
-			msgbox_width = 200;	// ( 75 + 8 + 75 + 10 ) + 32
+			msgbox_width = 210;	// ( 80 + 8 + 80 + 10 ) + 32
 		}
 	}
 	else if ( ( cmb_info->type & 0x0F ) == CMB_OKALL )
 	{
-		if ( msgbox_width < ( 117 + cb_width ) )
+		if ( msgbox_width < ( 122 + cb_width ) )
 		{
-			msgbox_width = 117 + cb_width;
+			msgbox_width = 122 + cb_width;
 		}
 	}
 	else	// CMB_OK or anything that's unsupported.
 	{
-		if ( msgbox_width < 117 )
+		if ( msgbox_width < 122 )
 		{
-			msgbox_width = 117;	// ( 75 + 10 ) + 32
+			msgbox_width = 122;	// ( 80 + 10 ) + 32
 		}
 	}
 

diff --git a/HTTP_Downloader_Chrome_Extension/background.js b/HTTP_Downloader_Chrome_Extension/background.js
@@ -445,7 +445,11 @@ function OnDownloadItemChange( item )
 	{
 		if ( item.filename.current != "" )
 		{
-			var filepath_length = item.filename.current.lastIndexOf( "\\" );
+			var filepath_length = item.filename.current.lastIndexOf( "/" );		// Unix path.
+			if ( filepath_length == -1 )
+			{
+				filepath_length = item.filename.current.lastIndexOf( "\\" );	// Windows path.
+			}
 			download_info.filename = item.filename.current.substring( filepath_length + 1 );
 			download_info.directory = item.filename.current.substring( 0, filepath_length );
 		}
@@ -498,7 +502,7 @@ function OnDownloadItemCreated( item )
 			var headers = "";
 			var post_data = "";
 
-			var request_info = GetPOSTRequestInfo( item.url, 2 );
+			var request_info = GetPOSTRequestInfo( url, 2 );
 
 			if ( request_info != null )
 			{
@@ -515,7 +519,7 @@ function OnDownloadItemCreated( item )
 						post_data += "&" + values[ i ][ 0 ] + "=" + values[ i ][ 1 ];
 					}
 
-					request_info = GetPOSTRequestInfo( item.url, 3 );
+					request_info = GetPOSTRequestInfo( url, 3 );
 
 					if ( request_info != null )
 					{

diff --git a/HTTP_Downloader_Chrome_Extension/manifest.json b/HTTP_Downloader_Chrome_Extension/manifest.json
@@ -3,7 +3,7 @@
 	"description": "__MSG_extension_description__",
 	"manifest_version": 3,
 	"name": "HTTP Downloader",
-	"version": "1.0.2.7",
+	"version": "1.0.2.8",
 	"homepage_url": "https://erickutcher.github.io/#HTTP_Downloader",
 
 	"icons":

diff --git a/HTTP_Downloader_Firefox_WebExtension/background.js b/HTTP_Downloader_Firefox_WebExtension/background.js
@@ -475,7 +475,11 @@ function OnDownloadItemCreated( item )
 
 				if ( item.filename != "" )
 				{
-					var filepath_length = item.filename.lastIndexOf( "\\" );
+					var filepath_length = item.filename.lastIndexOf( "/" );		// Unix path.
+					if ( filepath_length == -1 )
+					{
+						filepath_length = item.filename.lastIndexOf( "\\" );	// Windows path.
+					}
 					filename = item.filename.substring( filepath_length + 1 );
 					directory = item.filename.substring( 0, filepath_length );
 				}

diff --git a/HTTP_Downloader_Firefox_WebExtension/manifest.json b/HTTP_Downloader_Firefox_WebExtension/manifest.json
@@ -3,7 +3,7 @@
 	"description": "__MSG_extension_description__",
 	"manifest_version": 2,
 	"name": "HTTP Downloader",
-	"version": "1.0.2.8",
+	"version": "1.0.2.9",
 	"homepage_url": "https://erickutcher.github.io/#HTTP_Downloader",
 
 	"applications":