-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bzlmod support #17
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces Bazel module support to the project. It adds a MODULE.bazel file to define the module and its dependencies, and a BUILD file to define the cc_library target for the project. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcushultman - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
exports_includes
to avoid exposing the header file's location to users. - It's good practice to include a
LICENSE
file in the repository to clarify the licensing terms.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -0,0 +1,5 @@ | |||
"linenoise" | |||
|
|||
module(name='linenoise.cpp', version = "0.1.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Avoid using a file extension in the module name.
Module names typically represent a logical grouping; including '.cpp' may be misleading if the module contains more than just this file.
module(name='linenoise.cpp', version = "0.1.0") | |
module(name='linenoise', version = "0.1.0") |
@@ -0,0 +1,10 @@ | |||
cc_library( | |||
name = "linenoise-cpp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linenoise.cpp
cannot be used, since it presumably conflicts with the cpp file.
I have a feeling the BUILD file is could be causing macOS build to fail, if we change the name of one of the things it might work. |
@ericcurtin Not sure how I can be affecting cmake builds with this diff. The build log says: |
Summary by Sourcery
Introduce bzlmod support by adding a MODULE.bazel file and a BUILD file for the linenoise-cpp library.
Build: