throw on error of htmlmin error for grunt, so a build fails, now it is silent

.editorconfig

@@ -0,0 +1,19 @@
+[*]
+charset=utf-8
+end_of_line=lf
+insert_final_newline=false
+indent_style=space
+indent_size=2
+
+[{.babelrc,.stylelintrc,.eslintrc,*.bowerrc,*.jsb3,*.jsb2,*.json}]
+indent_style=space
+indent_size=2
+
+[{jshint.json,*.jshintrc}]
+indent_style=space
+indent_size=2
+
+[{*.yml,*.yaml}]
+indent_style=space
+indent_size=2
+

.gitignore

@@ -1,3 +1,5 @@
 node_modules
 npm-debug.log
 tmp
+grunt-angular-templates.iml
+.idea

Gruntfile.js

@@ -141,16 +141,16 @@ module.exports = function(grunt) {
         src: ['test/fixtures/one.html', 'test/fixtures/two/**/*.html'],
         dest: 'tmp/custom_htmlmin.js',
         options: {
-          htmlmin: {
-            collapseBooleanAttributes:      true,
-            collapseWhitespace:             true,
-            removeAttributeQuotes:          true,
-            removeComments:                 true,
-            removeEmptyAttributes:          true,
-            removeRedundantAttributes:      true,
-            removeScriptTypeAttributes:     true,
-            removeStyleLinkTypeAttributes:  true
-          }
+            htmlmin: {
+                collapseBooleanAttributes: true,
+                collapseWhitespace: true,
+                removeAttributeQuotes: true,
+                removeComments: true,
+                removeEmptyAttributes: true,
+                removeRedundantAttributes: true,
+                removeScriptTypeAttributes: true,
+                removeStyleLinkTypeAttributes: true
+            }
         }
       },
 
@@ -307,7 +307,9 @@ module.exports = function(grunt) {
         options: {
           merge: false
         }
-      }
+      },
+
+
     }
   });
 
@@ -355,6 +357,32 @@ module.exports = function(grunt) {
     grunt.task.run(tasks);
   });
 
+  grunt.registerTask('throwsOnErrorForHtmlminTest', function() {
+    grunt.config.merge(
+    {
+      ngtemplates: {
+        throwsOnErrorForHtmlminTest: {
+          options: {
+            htmlminThrowOnError: true,
+              htmlmin: {
+              collapseBooleanAttributes: true,
+                collapseWhitespace: true,
+                removeAttributeQuotes: true,
+                removeComments: true,
+                removeEmptyAttributes: true,
+                removeRedundantAttributes: true,
+                removeScriptTypeAttributes: true,
+                removeStyleLinkTypeAttributes: true
+            }
+          },
+          src: ['test/fixtures/htmlmin-throw-on-error.html'],
+            dest: 'tmp/htmlmin-throw-on-error.js'
+        }
+      }
+    });
+    grunt.task.run('ngtemplates:throwsOnErrorForHtmlminTest');
+  });
+
   // Load local tasks.
   grunt.loadTasks('tasks');
   grunt.loadNpmTasks('grunt-contrib-clean');

README.md

@@ -115,6 +115,13 @@ htmlmin: {
 }
 ```
 
+
+###htmlminThrowOnError
+Default: ```false```
+
+> If you set it to ```true```, it will throw an error. It is good for a build.  
+
+
 ### module
 
 > `String` of the `angular.module` to register templates with.

tasks/angular-templates.js

@@ -32,9 +32,11 @@ module.exports = function(grunt) {
       usemin:     null,
       append:     false,
       quotes:     'double',
-      merge:      true
+      merge:      true,
+      htmlminThrowOnError: false,
     });
 
+
     grunt.verbose.writeflags(options, 'Options');
 
     this.files.forEach(function(file) {

tasks/lib/compiler.js

@@ -125,6 +125,9 @@ var Compiler = function(grunt, options, cwd, expanded) {
         source = minify(source, options.htmlmin);
       } catch (err) {
         grunt.log.error(err + '\n\n' + source + '\n\n');
+        if (options.htmlminThrowOnError) {
+          throw err;
+        }
       }
     }
 

test/angular-templates_test.js

@@ -262,6 +262,29 @@ exports.ngtemplates = {
     test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/level2/html5.js'), grunt.file.read('test/expected/unmerged_files/html5.js'));
     test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/level2/level3/one.js'), grunt.file.read('test/expected/unmerged_files/one.js'));
     test.done();
+  },
+
+  throwsOnErrorForHtmlminTest: function (test) {
+    var findsError = 'Aborted due to warnings.';
+
+    var child = grunt.util.spawn({
+        cmd: 'grunt',
+        args: ['throwsOnErrorForHtmlminTest'],
+      }, function() {});
+
+    var result = '';
+    child.stdout.on('data', function (data) {
+      result += data;
+    });
+
+    child.stdout.on('end', function () {
+//      console.log(result);
+      if (result.indexOf(findsError) === -1) {
+        test.fail();
+      }
+      test.done();
+    });
+
   }
 
 };

test/fixtures/htmlmin-throw-on-error.html

@@ -0,0 +1,2 @@
+this shows an error
+<button