Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: fix dropped errors #1794

Closed
wants to merge 1 commit into from
Closed

irc: fix dropped errors #1794

wants to merge 1 commit into from

Conversation

alrs
Copy link

@alrs alrs commented Sep 12, 2021

This fixes two dropped err variables in the irc package.

@alrs
Copy link
Author

alrs commented Oct 5, 2021

Does this need anything else, @slingamn?

@slingamn
Copy link
Member

slingamn commented Oct 5, 2021

I think there is a potential change of behavior here since if the key is not found, we want errCasFailed but this will cause it to return buntdb.ErrNotFound instead.

@slingamn
Copy link
Member

slingamn commented Oct 5, 2021

The most defensive implementation would probably be:

		if err != nil || credStr != curCredStr {
			return errCASFailed
		}

@slingamn
Copy link
Member

This will get refactored in #1986

@slingamn slingamn closed this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants