-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dockerfile action support build context from user params #52
Merged
erda-bot
merged 6 commits into
erda-project:master
from
iutx:feat/dockerfile-support-build-context
Sep 13, 2024
Merged
feat: dockerfile action support build context from user params #52
erda-bot
merged 6 commits into
erda-project:master
from
iutx:feat/dockerfile-support-build-context
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ash <[email protected]>
iutx
force-pushed
the
feat/dockerfile-support-build-context
branch
from
September 12, 2024 08:56
23ac102
to
9367319
Compare
Signed-off-by: Ash <[email protected]>
Signed-off-by: Ash <[email protected]>
Signed-off-by: Ash <[email protected]>
Signed-off-by: Ash <[email protected]>
iutx
changed the title
feat: dockerfile action support build context from user input
feat: dockerfile action support build context from user params
Sep 12, 2024
sfwn
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add examples in README pls.
Signed-off-by: Ash <[email protected]>
Done. PTAL |
sfwn
approved these changes
Sep 13, 2024
/approve |
erda-bot
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dockerfile action support build context from user input.
Checklist