Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerfile action support build context from user params #52

Merged

Conversation

iutx
Copy link
Member

@iutx iutx commented Sep 12, 2024

Description

dockerfile action support build context from user input.

Checklist

  • I made sure to check the compatibility of the erda version statemented in the action's spec.yml.
  • My change is adequately tested.

@iutx iutx force-pushed the feat/dockerfile-support-build-context branch from 23ac102 to 9367319 Compare September 12, 2024 08:56
@iutx iutx changed the title feat: dockerfile action support build context from user input feat: dockerfile action support build context from user params Sep 12, 2024
@iutx iutx requested a review from sfwn September 12, 2024 09:30
Copy link
Member

@sfwn sfwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add examples in README pls.

@iutx
Copy link
Member Author

iutx commented Sep 13, 2024

Add examples in README pls.

Done. PTAL

@iutx iutx requested a review from sfwn September 13, 2024 01:33
@sfwn
Copy link
Member

sfwn commented Sep 13, 2024

/approve

@erda-bot erda-bot added the approved Approve merging these changes label Sep 13, 2024
@erda-bot erda-bot merged commit f19b50b into erda-project:master Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approve merging these changes
Development

Successfully merging this pull request may close these issues.

3 participants