Skip to content

feat: update package json for npm publish #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huaweigu merged 3 commits into from
Mar 27, 2025
Merged

feat: update package json for npm publish #205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79a2e23
feat: update package json for npm publish
huaweigu Nov 6, 2024
c867c19
Merge branch 'develop' into feat/npm
huaweigu Mar 25, 2025
2bbfacc
fix: update package name
huaweigu Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ broadcast/**/dry-run/**/*
# misc
.DS_Store
**/.DS_Store
.npmrc
23 changes: 20 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,31 @@
{
Copy link
Contributor Author

@huaweigu huaweigu Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaypaik Let me know if we need to adjust any metadata, thanks!

Copy link
Collaborator

@jaypaik jaypaik Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

"name": "@erc6900/reference-implementation",
"version": "0.8.0-rc.5",
"name": "erc6900-reference-implementation",
Copy link
Contributor Author

@huaweigu huaweigu Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tired the original name first, but got

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@erc6900%2freference-implementation - Not found
npm ERR! 404 
npm ERR! 404  '@erc6900/[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

This solution or this doc requires the user to sign up with erc6900 scope, but it is already in use..

Copy link
Collaborator

@jaypaik jaypaik Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I submitted a name dispute request. Would love to keep the org scope if possible...

Copy link
Contributor Author

@huaweigu huaweigu Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it'd be great if we can get erc6900 back. I tried user name and org name, both unavailable..

"description": "Reference implementation for [ERC-6900](https://eips.ethereum.org/EIPS/eip-6900).",
"version": "0.8.0-rc.6",
Copy link
Collaborator

@jaypaik jaypaik Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huaweigu Mind bumping this to 0.8.1 and updating the package name/relevant bits now that we have the erc6900 org on npm?

Copy link
Contributor Author

@huaweigu huaweigu Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 2bbfacc

I also published the package here

"devDependencies": {
"pnpm": "^8.7.5",
"solhint": "^3.6.2"
},
"files": [
"/src/**/*.sol"
],
"scripts": {
"lint": "pnpm lint:src && pnpm lint:test && pnpm lint:script",
"lint:src": "solhint --max-warnings 0 -c .solhint-src.json './src/**/*.sol'",
"lint:test": "solhint --max-warnings 0 -c .solhint-test.json './test/**/*.sol'",
"lint:script": "solhint --max-warnings 0 -c .solhint-script.json './script/**/*.sol'"
}
},
"repository": {
"type": "git",
"url": "https://github.com/erc6900/reference-implementation.git"
},
"keywords": [
"erc6900"
],
"author": "ERC6900 Community",
"license": "GPL-3.0",
"bugs": {
"url": "https://github.com/erc6900/reference-implementation/issues"
},
"homepage": "https://github.com/erc6900/reference-implementation#readme"
}