Update code and tests to same as xtgeo.plot #29
Merged
+413
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
approved these changes
Dec 7, 2023
janbjorge
reviewed
Dec 7, 2023
| @@ -36,6 +36,7 @@ def __init__(self): | |||
| self._tight = False | |||
| self._showok = True | |||
| self._fig = None | |||
| self._allfigs = [] | |||
There was a problem hiding this comment.
i have a weak-feeling that this should maybe be a weakref. My thinking being, if you have a few figures open and close one of them. The closing figures memory should be cleared then and not hang around until all a closed.
There was a problem hiding this comment.
I'm not so sure about this either. Hopefully we can come back to this code at some point. But for now, it's just copying the current state of xtgeo.plot to here.
I made an issue for it: #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25