-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: optimize speed for surface_from_grid method #1261
Conversation
301775d
to
674080e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 80.02% 81.14% +1.11%
==========================================
Files 98 94 -4
Lines 13680 12433 -1247
Branches 2203 1874 -329
==========================================
- Hits 10948 10089 -859
+ Misses 1999 1685 -314
+ Partials 733 659 -74 ☔ View full report in Codecov by Sentry. |
ecabde7
to
e186c8a
Compare
e186c8a
to
01d8c15
Compare
01d8c15
to
a702b79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive performance gains. OpenMP is magic
a702b79
to
0194990
Compare
Why we need to set OMP_NUM_THREADS to 1 to make "big" work is currently unknown.
Closes #1262
Main elements
std::array
instead ofstd::vector
. In particular the function that receives the corner coordinates, which has fixed length 24. In a future change, we should considerstructs
in steadIn a concrete case I have, these changes will in effect change the execution for HC thickness maps fram 4-5 minutes to 10 seconds