[Persistence]: Implement module persistence for VFP #1246
+11,555
−1,150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rontend-implementation
…rontend-implementation
jorgenherje
force-pushed
the
module-states/vfp
branch
from
2e08999 to
3a32b6f
Compare
jorgenherje
force-pushed
the
module-states/vfp
branch
from
3a32b6f to
4011a95
Compare
jorgenherje
force-pushed
the
module-states/vfp
branch
from
4011a95 to
d804c77
Compare
- Add module persistence - Minor code clean-up. Simplify interface, and prevent creating instance of VfpApiDataAccessor in both settings and view component. - Improve guards in plot builder to prevent crash. - Create plot builder hook for reference stability
jorgenherje
force-pushed
the
module-states/vfp
branch
2 times, most recently
from
eb17463 to
6da1d14
Compare
"Add StatusWrapper and modify PendingWrapper" - New StatusWrapper component - Use StatusWrapper in PendingWrapper
jorgenherje
force-pushed
the
module-states/vfp
branch
from
6da1d14 to
2c637ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/rubenthoms/webviz/tree/persistence/frontend-implementation