Skip to content

Conversation

@HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Oct 6, 2025

No description provided.

@HansKallekleiv HansKallekleiv requested a review from Copilot October 6, 2025 17:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automatic parameter selection for the correlation matrix module. When no user interaction has occurred, the system will automatically select parameters up to a limit of 100, or select the first parameter group if there are more than 100 available parameters.

  • Refactors parameter selection logic to distinguish between user-selected and automatically-selected parameters
  • Adds auto-selection behavior that activates when users haven't interacted with parameter selection
  • Implements fallback handling for cases where no parameters are available

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
correlationMatrixTimeSeries.ts Updates template to use new userSelectedParameterIdents property name
view/view.tsx Adds warning display when no parameters are selected or available
settings/settings.tsx Refactors to use new atom structure and derived parameter selection logic
components/parameterSelector.tsx Changes default auto-select behavior and simplifies group change handling
atoms/derivedAtoms.ts Implements core auto-selection logic with available and selected parameter atoms
atoms/baseAtoms.ts Adds new atoms for tracking user interaction and received channels
interfaces.ts Updates interface to use derived selected parameters atom

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HansKallekleiv HansKallekleiv changed the title Auto select parameters corr matrix Improve parameter selection ParameterCorrelationMatrix Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant