-
Notifications
You must be signed in to change notification settings - Fork 11
Improve parameter selection ParameterCorrelationMatrix #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve parameter selection ParameterCorrelationMatrix #1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic parameter selection for the correlation matrix module. When no user interaction has occurred, the system will automatically select parameters up to a limit of 100, or select the first parameter group if there are more than 100 available parameters.
- Refactors parameter selection logic to distinguish between user-selected and automatically-selected parameters
- Adds auto-selection behavior that activates when users haven't interacted with parameter selection
- Implements fallback handling for cases where no parameters are available
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| correlationMatrixTimeSeries.ts | Updates template to use new userSelectedParameterIdents property name |
| view/view.tsx | Adds warning display when no parameters are selected or available |
| settings/settings.tsx | Refactors to use new atom structure and derived parameter selection logic |
| components/parameterSelector.tsx | Changes default auto-select behavior and simplifies group change handling |
| atoms/derivedAtoms.ts | Implements core auto-selection logic with available and selected parameter atoms |
| atoms/baseAtoms.ts | Adds new atoms for tracking user interaction and received channels |
| interfaces.ts | Updates interface to use derived selected parameters atom |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
frontend/src/modules/ParameterResponseCorrelationMatrixPlot/settings/atoms/derivedAtoms.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/ParameterResponseCorrelationMatrixPlot/view/view.tsx
Show resolved
Hide resolved
…ttings/atoms/derivedAtoms.ts Co-authored-by: Copilot <[email protected]>
…ix' into auto-select-parameters-corr-matrix
No description provided.