Skip to content

Better diagnostics for duplicate headers #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Strepto wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better diagnostics for duplicate headers #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754fce9
Better diagnostics for duplicate headers
Strepto Jun 12, 2025
c7f2c11
Merge branch 'master' into nih/feat/scaff-header-diagnostics
Strepto Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 39 additions & 13 deletions CadRevealFbxProvider/Attributes/ScaffoldingAttributeParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,45 @@ private static string[] RemoveCsvNonDescriptionHeaderInfo(string[] fileLines)

private static ICsvLine[] ConvertToCsvLines(string[] fileLines)
{
return CsvReader
.ReadFromText(
String.Join(Environment.NewLine, fileLines),
new CsvOptions()
{
HeaderMode = HeaderMode.HeaderPresent,
RowsToSkip = 0,
SkipRow = (ReadOnlyMemory<char> row, int idx) => row.Span.IsEmpty || row.Span[0] == '#' || idx == 2,
TrimData = true,
Separator = ';',
}
)
.ToArray();
const char expectedSeparator = ';';
try
{
return CsvReader
.ReadFromText(
String.Join(Environment.NewLine, fileLines),
new CsvOptions()
{
HeaderMode = HeaderMode.HeaderPresent,
RowsToSkip = 0,
SkipRow = (ReadOnlyMemory<char> row, int idx) =>
row.Span.IsEmpty || row.Span[0] == '#' || idx == 2,
TrimData = true,
Separator = expectedSeparator,
}
)
.ToArray();
}
catch (Exception e)
{
if (e.Message.Contains("Duplicate headers detected in HeaderPresent mode."))
Copy link

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on substring matching of the exception message to detect duplicate headers can be fragile. Consider catching a more specific exception type if available or checking a dedicated error code.

Copilot uses AI. Check for mistakes.
{
var headerRow = fileLines.First();
Console.WriteLine(
Copy link

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Console.WriteLine for diagnostics in production code may not be the best choice. Consider using a structured logging framework to improve maintainability and traceability.

Copilot uses AI. Check for mistakes.
"The first row of the CSV file is expected to contain unique headers. Current headers: \n "
+ headerRow
);

var duplicateHeaders = headerRow
.Split(expectedSeparator)
.GroupBy(h => h.Trim())
.Where(g => g.Count() > 1)
.Select(g => g.Key)
.ToList();
Console.WriteLine("Duplicate headers found: " + string.Join(", ", duplicateHeaders));
Console.WriteLine("This should not happen, the scaffolding file is invalid.");
}
throw;
}
}

private static int RetrieveKeyAttributeColumnIndex(ICsvLine[] attributeRawData)
Expand Down
Loading