Extend the scaffold optimizer framework to enable use of primitives #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s results from optimizations. Also, fix handling of instance IDs for split meshes.
Strepto
approved these changes
Sep 17, 2024
Collaborator
Strepto
left a comment
Strepto
left a comment
There was a problem hiding this comment.
Ok by me, not sure if its the best approach but I dont have any better suggestions. So lets try this one 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the scaffold optimizer framework to enable use of primitives as results from optimizations by enable the return of an array of optimization results that contain APrimitives. The array can contain a mix of instances, triangles, or any of the available primitives.
Also, this will fix handling of instance IDs for split meshes by assigning new instance IDs for each instance mesh of a split mesh.