CI: Test with ert in test dependencies #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
add-ert-tests
branch
from
8b544f4 to
1ee24e0
Compare
mferrera
force-pushed
the
add-ert-tests
branch
from
20aa02b to
d760a24
Compare
tnatt
approved these changes
Dec 9, 2024
| @@ -6,6 +6,8 @@ | |||
| import pytest | |||
| import yaml | |||
|
|
|||
| pytest.importorskip("ert") | |||
There was a problem hiding this comment.
Was not aware of this functionality, that was handy!
There was a problem hiding this comment.
It's a new one to me too. Can be used in functions as well 🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the secondary ert-only CI jobs and tests everything together. That might not categorically be an improvement, but it seems to run everything a bit faster.
After moving to Python 3.11 for windows, the tests were taking over an hour to complete, so it was dropped in this PR.