MAINT: Move schemas to 'schemas/' #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
deploy-schemas-dir-directly
branch
from
da35e09 to
073c56d
Compare
mferrera
force-pushed
the
deploy-schemas-dir-directly
branch
2 times, most recently
from
8f7b4f8 to
98412ca
Compare
This creates a distinct directory that we will serve from the Radix endpoint. The script that modifies the id when the Docker image starts is still present, but modified. It will be removed when the schemas URLs are set from the relevant branch (main for dev, staging for prod).
mferrera
force-pushed
the
deploy-schemas-dir-directly
branch
from
98412ca to
fcaafe9
Compare
|
In #944 I didn't realize I had to update the .dockerignore file as well. It's fixed in this PR. |
tnatt
approved these changes
Jan 3, 2025
| @@ -13,7 +13,7 @@ def test_schema_uptodate(): | |||
| To update the local schema, run: | |||
| `./tools/update_schema` | |||
| """ | |||
| with open("schema/definitions/0.8.0/schema/fmu_results.json") as f: | |||
| with open("schemas/0.8.0/fmu_results.json") as f: | |||
There was a problem hiding this comment.
While in here, should we take the version from the FmuResultsSchema.VERSION maybe?
There was a problem hiding this comment.
Yes, good point. I'm touching a lot of this code in a PR I'm working on now so I'm going skip it for this one and include in the next one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #895
Stacked on #944
This change expects that the contents of
schemas/is exactly what will be served over the Radix endpoint. It simplifies a few things in order to expand the selection of schemas we will serve, in particular the file schema being created for the inplace volumes product.