TST: Check required inplace volumes columns #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
commented
Dec 19, 2024
Comment on lines
+67
to
+73
| @staticmethod | ||
| def required_columns() -> list[str]: | ||
| """Returns a list of the columns required at export.""" | ||
| return ( | ||
| InplaceVolumes.required_index_columns() | ||
| + InplaceVolumes.required_value_columns() | ||
| ) |
There was a problem hiding this comment.
This is becoming a kind of verbose "enum". I think it's OK for now, but I can see that the current module/subpackage layout will need adjustment for the next one. It's probably a bit too early to see how that should look now
tnatt
approved these changes
Dec 20, 2024
| @@ -34,7 +34,7 @@ class InplaceVolumesResultRow(BaseModel): | |||
| BULK: float = Field(ge=0.0) | |||
| NET: Optional[float] = Field(default=None, ge=0.0) | |||
| PORV: float = Field(ge=0.0) | |||
| HCPV: Optional[float] = Field(default=None, ge=0.0) | |||
mferrera
force-pushed
the
check-inplace-vols-required-columns
branch
from
851fcf4 to
e31042e
Compare
mferrera
force-pushed
the
check-inplace-vols-required-columns
branch
from
e31042e to
1f2c116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #928
Caught that
HCPVwas not set to required in the Pydantic model ✅