ENH: Faultroom export - add mapping of juxt.pos. to SMDA names (#724) #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
from
8bb0e02 to
bd82f04
Compare
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
7 times, most recently
from
27f5595 to
2102d21
Compare
mferrera
reviewed
Dec 11, 2024
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
3 times, most recently
from
06d5791 to
cd2b240
Compare
tnatt
reviewed
Dec 16, 2024
tnatt
reviewed
Dec 16, 2024
|
Need to get some info from Ingunn to find the best way forward regarding some of these issues |
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
3 times, most recently
from
505e04d to
8e69a67
Compare
|
OK with no-ordering and warning, @tnatt ? |
tnatt
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Looks much cleaner now yes 🙂 and functionality is according to our latest discussion!
My only other suggestion would be to move the method from the pydantic class to another place, to limit pydantic class scopes to primarily data storage and validation. But not that important 🙂
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
3 times, most recently
from
11bef60 to
34a0a78
Compare
|
I didn't really find another suitable place, so I made one myself 😊 |
ErichSuter
force-pushed
the
724-faultroom-export-lacks-map-juxtapositions
branch
from
34a0a78 to
5c67e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #724, and sorts the mapped names according to the given stratigraphic column.
Discussion on Slack: https://equinor.slack.com/archives/C06E3UTGTEV/p1719922723901579