Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test dependency on scikit learn #9917

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 30, 2025

Seems overkill just to normalize a matrix.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Jan 30, 2025
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9917 will not alter performance

Comparing larsevj:remove_scikit_learn_test_dependency (70cc18d) with main (bc9f17b)

Summary

✅ 25 untouched benchmarks

@larsevj larsevj merged commit ea89e01 into equinor:main Jan 30, 2025
27 checks passed
@larsevj larsevj deleted the remove_scikit_learn_test_dependency branch January 30, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants