Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more validation to design matrix #9915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add more validation to design matrix #9915

wants to merge 2 commits into from

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Jan 30, 2025 •
edited
Loading

Issue
Resolves #8686

Approach
The commits in this PR add more validation to design matrix

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq force-pushed the validate-design-matrix branch from ef743e9 to 09a6a89 Compare January 30, 2025 11:13
@jonathan-eq jonathan-eq added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 30, 2025
@jonathan-eq
Have active_realizations_field only accept realizations found in desi…
409bdc2 
…gn matrix
@jonathan-eq
Add more DesignMatrix validation
dc7757f 
This commit adds some more validation to the designmatrix:
 * Empty parameter name in design matrix
 * Whitespace parameter name
 * Number as parameter name
 * Spaces in parameter name (multiple words)
 * Outputs all validationerrors it finds, instead of only one
@jonathan-eq jonathan-eq force-pushed the validate-design-matrix branch from 09a6a89 to dc7757f Compare January 30, 2025 11:17
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9915 will not alter performance

Comparing jonathan-eq:validate-design-matrix (dc7757f) with main (050077c)

Summary

✅ 25 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that DESIGN_MATRIX is correct upon initialization
1 participant
@jonathan-eq