Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq: make sure to destroy evaluator context in case zmq fails on startup #9905

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Jan 29, 2025

Issue
In case zmq fails on startup this makes sure it closes properly.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Jan 29, 2025
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9905 will improve performances by 10.23%

Comparing xjules:backport_13 (57653ad) with main (3b6f51e)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.3 ms +10.23%
⁉️ test_plotter_on_all_snake_oil_responses_time[0] 11 s N/A N/A

@xjules xjules merged commit 0138762 into equinor:version-13.0 Jan 29, 2025
26 of 27 checks passed
@xjules xjules deleted the backport_13 branch January 29, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants