Deprecate backend options #9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9899 will not alter performanceComparing Summary
|
yngve-sk
force-pushed
the
25.01.29.remove-backend
branch
from
7168afb to
50a0833
Compare
verveerpj
reviewed
Jan 29, 2025
DanSava
reviewed
Jan 29, 2025
Comment on lines
69
to
75
| message = ( | ||
| "sampler.backend is deprecated. " | ||
| "The correct backend will be inferred by the method. " | ||
| "If several backends have a method named A and you want to pick " | ||
| "a specific backend B, put B/A in sampler.method." | ||
| ) | ||
| print(message) |
There was a problem hiding this comment.
Shouldn't this deprecation message come from everest/config/sampler_config.py ?
DanSava
reviewed
Jan 29, 2025
Comment on lines
271
to
277
| message = ( | ||
| "optimization.backend is deprecated. " | ||
| "The correct backend will be inferred by the algorithm. " | ||
| "If several backends have an algorithm named A and you want to pick " | ||
| "a specific backend B, put B/A in optimization.algorithm." | ||
| ) | ||
| print(message) |
There was a problem hiding this comment.
Shouldn't this be part of everest/config/optimization_config.py
yngve-sk
force-pushed
the
25.01.29.remove-backend
branch
2 times, most recently
from
4f23b33 to
3a6dcaf
Compare
yngve-sk
force-pushed
the
25.01.29.remove-backend
branch
from
3f0f631 to
445eefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9773