Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac select string #9839

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 22, 2025

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:build-system PR containing only build system changes label Jan 22, 2025
@eivindjahren eivindjahren enabled auto-merge (rebase) January 22, 2025 09:19
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9839 will improve performances by 11.37%

Comparing eivindjahren:fix_mac_select_string (c2698c0) with main (2839ae7)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main eivindjahren:fix_mac_select_string Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.6 ms 2.4 ms +11.37%

@eivindjahren eivindjahren merged commit 469868e into equinor:main Jan 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:build-system PR containing only build system changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants