Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip slow tests in mac ci #9833

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 22, 2025

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added release-notes:skip If there should be no mention of this in release notes release-notes:build-system PR containing only build system changes and removed release-notes:skip If there should be no mention of this in release notes labels Jan 22, 2025
@eivindjahren eivindjahren force-pushed the skip_slow_tests_on_mac branch from 5993c7e to d744e67 Compare January 22, 2025 07:14
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9833 will not alter performance

Comparing eivindjahren:skip_slow_tests_on_mac (ed5006b) with main (15109bb)

Summary

✅ 24 untouched benchmarks

@eivindjahren eivindjahren force-pushed the skip_slow_tests_on_mac branch from d744e67 to ed5006b Compare January 22, 2025 08:14
@eivindjahren eivindjahren enabled auto-merge (rebase) January 22, 2025 08:31
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eivindjahren eivindjahren merged commit 2839ae7 into equinor:main Jan 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:build-system PR containing only build system changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants