Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to have path object in argslist for localdriver #9825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unable to have path object in argslist for localdriver #9825

wants to merge 1 commit into from
+15 −3

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Jan 21, 2025 •
edited
Loading

Issue
Resolves #9217

Approach
Call str on the object before joining it.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 21, 2025
@jonathan-eq jonathan-eq self-assigned this Jan 21, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9825 will not alter performance

Comparing jonathan-eq:fix-bugs7 (15cfd15) with main (469868e)

Summary

✅ 24 untouched benchmarks

xjules
xjules reviewed Jan 22, 2025
View reviewed changes
tests/ert/unit_tests/scheduler/test_local_driver.py Outdated


@pytest.mark.timeout(10)
async def test_path_as_argument(tmp_path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for name: test_path_as_argument_is_valid

xjules
xjules approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for a new name of the test function and it is good to go. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

Assignees

@jonathan-eq jonathan-eq

Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to have a Path object in the argslist for LocalDriver
2 participants
@jonathan-eq @xjules