Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Slurm test setup to Ubuntu 24.04 #9823

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 21, 2025

Issue
Resolves #8931

Approach
ssh to a ubuntu 24.04 somewhere and try things out.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 21, 2025
@berland berland changed the title Adapt Slurm setup to Ubuntu 24.04 Adapt Slurm test setup to Ubuntu 24.04 Jan 21, 2025
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9823 will not alter performance

Comparing berland:slurm_ubuntu_latest (8a4f9d0) with main (6a978df)

Summary

✅ 24 untouched benchmarks

@berland berland force-pushed the slurm_ubuntu_latest branch from cb9aebe to 6da0538 Compare January 21, 2025 11:34
@berland berland force-pushed the slurm_ubuntu_latest branch from 6da0538 to 8a4f9d0 Compare January 21, 2025 11:51
@berland berland self-assigned this Jan 21, 2025
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland berland merged commit 56f6ec4 into equinor:main Jan 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider unpinning ubuntu runner image for test-ert-on-slurm workflow
2 participants