Refactor everserver 2 #9777
Open
Refactor everserver 2 #9777
+375
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
from
3058d26 to
249e947
Compare
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
from
249e947 to
d0b2ca4
Compare
CodSpeed Performance ReportMerging #9777 will improve performances by 12.73%Comparing Summary
Benchmarks breakdown
|
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
from
1e6e488 to
071bbbc
Compare
frode-aarstad
added
the
release-notes:maintenance
oyvindeide
reviewed
Jan 20, 2025
| def extract_errors_from_file(path: str): | ||
| with open(path, encoding="utf-8") as f: | ||
| content = f.read() | ||
| return re.findall(r"(Error \w+.*)", content) | ||
|
|
||
|
|
||
| def wait_for_server_simple( |
There was a problem hiding this comment.
Would it be possible to join this with wait_for_server?
There was a problem hiding this comment.
This function is simpler and does not have to handle the strange edge cases in wait_for_server
There was a problem hiding this comment.
But some of those edge cases cant really happen anymore? Like this from line 155:
# For very small cases the optimization will finish and bring down the
# server before we can verify that it is running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9290
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable