-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve experiment/ensemble name validation in GUI #8646
Improve experiment/ensemble name validation in GUI #8646
Conversation
ff4b28e
to
2da1b88
Compare
Current status:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8646 +/- ##
==========================================
+ Coverage 90.90% 90.96% +0.06%
==========================================
Files 343 343
Lines 21271 21288 +17
==========================================
+ Hits 19336 19365 +29
+ Misses 1935 1923 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3e40436
to
ca1eaff
Compare
There are still some remaining issues:
I think this should still work fine if you have already duplicate experiment names in storage, validation only happens when you try to create a new experiment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but think there might be something with restart runs with es-mda? If I run an ensemble experiment, and then switch to the es-mda tab and manually enter: ensemble_experiment
as the name, and then check the Restart run
checkbox I am not able to start an experiment.
Also feel free to rebase and force push.
77445d8
to
f6b1ab7
Compare
Should be fixed now. |
f6b1ab7
to
25b3f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Issue
Resolves #8612
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable