Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when active realizations differ from num realizations #10340

Conversation

larsevj
Copy link
Collaborator

@larsevj larsevj commented Mar 17, 2025

Issue

Changes in GUI:

image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Sorry, something went wrong.

Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10340 will not alter performance

Comparing larsevj:warn_when_active_realizations_differ_from_num_realizations (0932cb6) with main (e54cf32)

Summary

✅ 25 untouched benchmarks

@larsevj larsevj force-pushed the warn_when_active_realizations_differ_from_num_realizations branch from 4d0e93a to 6a89b4d Compare March 18, 2025 09:37
@larsevj larsevj force-pushed the warn_when_active_realizations_differ_from_num_realizations branch from 6a89b4d to 0932cb6 Compare March 19, 2025 11:35
@larsevj larsevj self-assigned this Mar 19, 2025
@larsevj larsevj added the release-notes:improvement Automatically categorise as improvement in release notes label Mar 19, 2025
@larsevj larsevj requested a review from oyvindeide March 19, 2025 15:12
@larsevj larsevj closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant