Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant test_ert_context #10333

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Mar 17, 2025

This test is nearly identical to
test_that_config_path_substitution_is_the_name_of_the_configs_directory

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Mar 17, 2025
This test is nearly identical to
test_that_config_path_substitution_is_the_name_of_the_configs_directory
@eivindjahren eivindjahren force-pushed the remove_redundant_test branch from 2cc949b to 87bc173 Compare March 17, 2025 10:14
@eivindjahren eivindjahren changed the title Remove redudant test_ert_context Remove redundant test_ert_context Mar 17, 2025
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10333 will improve performances by 10.29%

Comparing eivindjahren:remove_redundant_test (87bc173) with main (92834bf)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7.1 ms 6.4 ms +10.29%

@eivindjahren eivindjahren self-assigned this Mar 17, 2025
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate!

@eivindjahren eivindjahren merged commit 790e6a7 into equinor:main Mar 17, 2025
27 checks passed
@eivindjahren eivindjahren deleted the remove_redundant_test branch March 17, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants