Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scaling warning to user and save user preferences to file. #10331

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Mar 17, 2025

Issue
Resolves #10099

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Mar 17, 2025
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10331 will not alter performance

Comparing DanSava:show-scaling-warning (02566e7) with main (0e8c9f2)

Summary

✅ 25 untouched benchmarks

@DanSava DanSava force-pushed the show-scaling-warning branch 2 times, most recently from 770b0c7 to 90f2f87 Compare March 17, 2025 11:14
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make the scaling printout a bit more verbose/explicit, added a suggestion. Otherwise looks really good!

@DanSava DanSava force-pushed the show-scaling-warning branch from 90f2f87 to 02566e7 Compare March 18, 2025 13:51
@DanSava DanSava merged commit 8cd83cb into equinor:main Mar 18, 2025
27 checks passed
@DanSava DanSava deleted the show-scaling-warning branch March 18, 2025 14:34
@DanSava DanSava added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify users that Everest will output scaled control values
2 participants