Better error message when experiment is terminated by user #10158

JHolba · 2025-02-26T14:19:29Z

Issue
Resolves #9960

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Create Backport PR to latest release

codspeed-hq · 2025-02-26T14:41:30Z

CodSpeed Performance Report

Merging #10158 will not alter performance

_{Comparing JHolba:fix_error_on_terminate_experiment (1f5b386) with main (d2f2ca9)}

Summary

✅ 25 untouched benchmarks

src/ert/run_models/base_run_model.py

jonathan-eq

I have some questions 🤔

jonathan-eq · 2025-03-07T06:51:35Z

src/ert/run_models/base_run_model.py

@@ -598,7 +605,8 @@ async def run_ensemble_evaluator_async(
        if not self._end_queue.empty():
            logger.debug("Run model canceled - pre evaluation")
            self._end_queue.get()
-            return []
+            raise UserCancelled("Experiment cancelled by user in pre evaluation")


Should we have tests for these different scenarios? (cancelling pre evaluation, during evaluation, and post evaluation)

I don't think we need specific tests for that 🤷

Have you manually tested that this works?

JHolba self-assigned this Feb 26, 2025

JHolba added the release-notes:improvement Automatically categorise as improvement in release notes label Feb 26, 2025

JHolba marked this pull request as ready for review February 26, 2025 14:36

JHolba changed the title ~~Change error message shown when experiment is terminated by user~~ Better error message when experiment is terminated by user Feb 26, 2025

JHolba force-pushed the fix_error_on_terminate_experiment branch from 9c2e575 to c0158cd Compare February 26, 2025 14:50