Hotfix quest1 complete survey bug #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| location.reload(); | ||
| const formData = { | ||
| [fieldMapping[moduleName].statusFlag]: fieldMapping.moduleStatus.submitted, | ||
| [fieldMapping[moduleName].completeTs]: data["COMPLETED_TS"], |
There was a problem hiding this comment.
I'm wondering if we should take Quest out of the equation when it comes to this? Just set the status flag as submitted and the complete ts as the current time within the PWA?
Then that makes me wonder if we just only have Quest send a COMPLETED flag to signal as such.
There was a problem hiding this comment.
That would be cleaner and I like it.
I still haven't figured out why Quest 1 is currently failing to send the COMPLETED flag in certain cases, which makes me think we need to catch that TS until migration to Quest 2 is complete.
I'll keep this on my radar for testing and cleanup as we refine Quest 2.
anthonypetersen
approved these changes
Jan 7, 2025
amber-emmes
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: episphere/connect#1183
Fix missing
COMPLETEDvalue on Quest 1 survey submission.