Modify default model config behaviour #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoishernandez
force-pushed
the
default_model_config_behaviour
branch
3 times, most recently
from
685a7b1 to
5d1641f
Compare
francoishernandez
force-pushed
the
default_model_config_behaviour
branch
from
5d1641f to
65ae395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5
Previously, we retained the concept of "default model architecture is encoder/decoder RNN", but that did not fit the modularity of the latest changes (notably when updating nested configurations from existing models).
With these changes, the
modelconfiguration key defaults toNonein the training code path, which makes it necessary to pass at least an architecture when training from scratch. An explicit error is raised in that sense. (Might still be improved/better documented.)