Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push rope back to encoder/decoder #208

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

vince62s
Copy link
Contributor

@vince62s vince62s commented Feb 11, 2025

@francoishernandez can you have a look for two things:

  • not sure why I had to change again the random lm output of tests
  • I did not touch the model config stuff, unsure if I have to.

EDIT:
ok the test failed because of the lm output. I think it comes from my pytorch version (I used nightly)

@francoishernandez
Copy link
Member

Note for reference: the config already has the required information at encoder/decoder level, so no changes are needed. The issue in #206 was that the "model-level" rope was grabbing the "model-level" configuration, which can be misaligned with the nested encoder/decoder configurations if the latter are defined explicitly. Pushing rope back at encoder/decoder level means we always take the up to date config (either deduced from model-level, and forwarded in validation, or explicitly set).

@vince62s vince62s merged commit 452d370 into eole-nlp:main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants