This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Use photon colors consistently #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ariasuni
|
|
This bug is already present in the current version of the extension and it seems it can’t be easily fixed programmatically. The icon displayed in the header bar and in the list is the same, but with the default dark theme of Firefox, one’s white and the other dark, and we can’t really know what’s the currently used color for each. The best fix I can see is to make an icon that works both on light and dark backgrounds, but’s that’s not the in the scope of this PR. Would you mind opening another issue for that? I’ll then copy/paste my comment there. |
|
Thanks. Here it is: #392 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix
about:addonsicon not colored correctly in dark theme and improve a bit new tab button margin and centering.