Repository navigation
ci: write CI Bazel flags to user.bazelrc instead of removed repo.bazelrc - #1638
Open
tomjzzhang wants to merge 3 commits into
Open
tomjzzhang wants to merge 3 commits into
tomjzzhang wants to merge 3 commits into
Conversation
When envoyproxy#1627 synced .bazelrc with upstream Envoy PR envoyproxy/envoy#47806, it removed try-import %workspace%/repo.bazelrc from the bottom of .bazelrc. However, .github/workflows/_ci.yml still writes the CI compiler and resource configurations to repo.bazelrc, so Bazel no longer loads those settings during CI runs. This PR replaces repo.bazelrc with user.bazelrc in .github/workflows/_ci.yml (and adds the upstream Envoy fallback in ci/do_ci.sh to copy repo.bazelrc to user.bazelrc if present), as user.bazelrc remains imported at the bottom of .bazelrc and ignored by .gitignore. Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #1627 synced
.bazelrcwith upstream Envoy PR envoyproxy/envoy#47806, it removedtry-import %workspace%/repo.bazelrcfrom the bottom of.bazelrc. However,.github/workflows/_ci.ymlstill writes the CI compiler and resource configurations torepo.bazelrc, so Bazel no longer loads those settings during CI runs.This PR replaces
repo.bazelrcwithuser.bazelrcin.github/workflows/_ci.yml(and adds the upstream Envoy fallback inci/do_ci.shto copyrepo.bazelrctouser.bazelrcif present), asuser.bazelrcremains imported at the bottom of.bazelrcand ignored by.gitignore.