Repository navigation
docs: add .github/config.yml and ci/envoy_build_sha.sh to Envoy update instructions - #1623
Merged
fei-deng merged 1 commit intoOct 1, 2026
Conversation
…e instructions Update manual Envoy dependency update instructions to include syncing .github/config.yml and ci/envoy_build_sha.sh from upstream Envoy. Renumber subsequent steps and fix internal step references accordingly. Signed-off-by: Jason Ye <jiajunye@google.com>
jiajunye
marked this pull request as ready for review
September 28, 2026 23:52
Contributor
|
Thanks for updating the update instruction! |
Contributor
|
@tomjzzhang please review. |
tomjzzhang
approved these changes
Sep 29, 2026
tomjzzhang
left a comment
tomjzzhang
left a comment
Contributor
There was a problem hiding this comment.
I think it's already reflected in the update script (nighthawk_envoy_updater.py) but just confirming that it matches the same behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
docs/root/updating_envoy_dependency.mdto:.github/config.ymlandci/envoy_build_sha.sh.cp -vfor all files that are copied verbatim from Envoy (.bazelversion,.github/config.yml,ci/envoy_build_sha.sh, andci/run_envoy_docker.sh).merge_from_envoy(Step 9) for files that require manual merging (Steps 10–12).