Support custom CRDs for ExtensionServer in Standalone Mode #7331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt scheme Teach the offline controller to recognise custom extension-server policy GVKs supplied by an extension so they can be decoded and later processed by the translator. - newOfflineGatewayAPIClient now accepts extServerPoliciesGVKs - each GVK is registered as Unstructured/UnstructuredList in the fake client's scheme - call-site updated to pass the collected policy GVKs Signed-off-by: daum3ns <[email protected]>
…backend resource registration Signed-off-by: daum3ns <[email protected]>
when reading from yaml Signed-off-by: daum3ns <[email protected]>
Add policy resources from ExtensionManager to extGKs so custom extension policies are recognised during translation. Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
server and policy resource Signed-off-by: daum3ns <[email protected]>
…f an EnvoyGateway configuration containing a standalone extension server. Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
yaml and it gets the default namespace Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
can check custom resource definitions Signed-off-by: daum3ns <[email protected]>
Signed-off-by: daum3ns <[email protected]>
daum3ns
force-pushed
the
support-custom-CRDs-for-ExtensionServer-in-Standalone-Mode
branch
from
1f7a84b to
d66478e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the file-based (standalone) provider to understand and load custom resources that are defined by an extension server.
LoadResourcesFromYAMLBytesnow accepts a server config pointer. When a resource kind is unknown, the loader checks the configured ExtensionManager and, if the GVK matches a declared policy resource, stores the object as an ExtensionServerPolicynewOfflineGatewayAPIClientfunction now accepts extensionServerPoliciesGVKs, which are then registered in the scheme. this allows the offline reconciler to manipulate custom resourcesFixes #7141
Release Notes: Yes/No
Notes:
I found out that we most probably have the same problem with ExtensionManagers
backendResourcesandresourcesfield (at least the config_loader test can easily be extended to show that the registration in the scheme is missing).I think it could be fixed in a similar way (although not sure whether the translator needs to be adapted as well). See the commented code snippets...
However, I'm very new to envoy-gateway so I'm still raising this PR to get a first, much appreciated feedback whether it makes sense to continue in this direction..