Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Oct 20, 2025

What this PR does / why we need it:
Adds support for Envoy PreconnectPolicy which allows users to configure proactive upstream connections to avoid connection overhead in latency sensitive services.

Which issue(s) this PR fixes:

Fixes #7254

Release Notes: Yes

@jukie jukie force-pushed the preconnect-policy branch from 0594790 to 98fce1b Compare October 20, 2025 19:42
@jukie jukie changed the title preconnect policy feat: Add support for upstream PreconnectPolicy Oct 20, 2025
@jukie jukie force-pushed the preconnect-policy branch from 98fce1b to 1ebcc6e Compare October 20, 2025 19:45
Signed-off-by: jukie <[email protected]>
@jukie jukie force-pushed the preconnect-policy branch from 1ebcc6e to 6d9b3ad Compare October 20, 2025 19:51
@jukie jukie requested a review from a team October 20, 2025 19:52
@jukie jukie marked this pull request as ready for review October 20, 2025 19:52
@jukie jukie requested a review from a team as a code owner October 20, 2025 19:52
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.00%. Comparing base (bb7ed01) to head (80c0f00).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7288      +/-   ##
==========================================
- Coverage   72.00%   72.00%   -0.01%     
==========================================
  Files         230      230              
  Lines       33347    33370      +23     
==========================================
+ Hits        24012    24028      +16     
- Misses       7589     7594       +5     
- Partials     1746     1748       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie
Copy link
Contributor Author

jukie commented Oct 20, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented Oct 21, 2025

/retest

1 similar comment
@jukie
Copy link
Contributor Author

jukie commented Oct 22, 2025

/retest

@arkodg arkodg added this to the v1.6.0-rc.1 Release milestone Oct 24, 2025
@jukie
Copy link
Contributor Author

jukie commented Oct 24, 2025

/retest

2 similar comments
@jukie
Copy link
Contributor Author

jukie commented Oct 24, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented Oct 24, 2025

/retest

@jukie jukie requested a review from arkodg October 25, 2025 22:27
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 25, 2025 23:11
@jukie
Copy link
Contributor Author

jukie commented Oct 26, 2025

/retest

1 similar comment
@jukie
Copy link
Contributor Author

jukie commented Oct 26, 2025

/retest

@zirain zirain merged commit 2454f9b into envoyproxy:main Oct 27, 2025
119 of 127 checks passed
@jukie jukie deleted the preconnect-policy branch October 27, 2025 02:51
linmosko pushed a commit to linmosko/gateway that referenced this pull request Oct 27, 2025
* preconnect policy

Signed-off-by: jukie <[email protected]>

* adjust fields

Signed-off-by: jukie <[email protected]>

* lint

Signed-off-by: jukie <[email protected]>

* descriptions, naming, and perEndpointPercent min vs max

Signed-off-by: jukie <[email protected]>

* test case and description tweak

Signed-off-by: jukie <[email protected]>

---------

Signed-off-by: jukie <[email protected]>
Signed-off-by: Isaac <[email protected]>
Signed-off-by: Lin Moskovitch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Envoy Upstream PreConnect Policy

3 participants