Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): use SDS to deliver system trust store to support dynamic reload #5084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Jan 17, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5074

Release Notes: Yes

@guydc guydc requested a review from a team as a code owner January 17, 2025 00:28
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.83%. Comparing base (27a2ef3) to head (9e3d054).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/translator.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5084      +/-   ##
==========================================
- Coverage   66.85%   66.83%   -0.03%     
==========================================
  Files         211      211              
  Lines       32916    32904      -12     
==========================================
- Hits        22007    21990      -17     
- Misses       9584     9588       +4     
- Partials     1325     1326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rotation of System WellKnownCACertificates in BTLSP
1 participant