Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance(experimental): enable grpc conformance profile #3976

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jul 31, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/gateway-api#3191 (comment)

@Xunzhuo Xunzhuo requested a review from a team as a code owner July 31, 2024 07:39
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (3dfa931) to head (ab61e56).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
+ Coverage   67.57%   67.62%   +0.04%     
==========================================
  Files         183      183              
  Lines       22406    22406              
==========================================
+ Hits        15141    15152      +11     
+ Misses       6187     6178       -9     
+ Partials     1078     1076       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo Xunzhuo requested a review from arkodg July 31, 2024 08:24
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team July 31, 2024 18:54
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guydc guydc merged commit 847d554 into envoyproxy:main Jul 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants